[SPARK-53792][SS] Fix rocksdbPinnedBlocksMemoryUsage when bounded memory … #52527
+73
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micheal-o
reviewed
Oct 6, 2025
...ore/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBMemoryManager.scala
Outdated
Show resolved
Hide resolved
...ore/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBMemoryManager.scala
Outdated
Show resolved
Hide resolved
...ore/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBMemoryManager.scala
Outdated
Show resolved
Hide resolved
micheal-o
reviewed
Oct 6, 2025
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala
Outdated
Show resolved
Hide resolved
zifeif2
force-pushed
the
pinned-block-mem
branch
from
adc1a70 to
0375604
Compare
zifeif2
changed the title
zifeif2
force-pushed
the
pinned-block-mem
branch
from
0375604 to
1ac1e8a
Compare
micheal-o
approved these changes
Oct 7, 2025
| */ | ||
| def getInstancePinnedBlocksMemUsage( | ||
| uniqueId: String, | ||
| pinnedUsage: Long): Long = { |
There was a problem hiding this comment.
nit: param name pinnedUsage is different from what is in the description globalPinnedUsage. Lets just name this param as: totalPinnedUsage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…usage is enabled
What changes were proposed in this pull request?
Changing the way we calculate
pinnedBlocksMemUsagewhen an instance has bounded memory enabled.Before the change, we always report back
getDBProperty("rocksdb.block-cache-pinned-usage")which returns that size of pinned block requested by an instance. This is not accurate when instances share the same cached, because instances might share the same pinned blockAfter this change, when isMemoryBounded is enabled for an instance, we call
lruCache.getPinnedUsage()to get the total memory usage of SHARED pinned blocks, and divide the global usage with the number of IS_MEMORY_BOUNDED instances. This is because RocksDBMemoryManager will return the same cache for all the instance that has isMemoryBounded = trueUnit test:
build/mvn -Dtest=none -DwildcardSuites=org.apache.spark.sql.execution.streaming.state.RocksDBSuite test
Why are the changes needed?
See above for why this is a bug.
This fix prevents us from over-reporting
pinnedBlocksMemUsagewhen isBoundedMemory is enabled for an instanceDoes this PR introduce any user-facing change?
No
How was this patch tested?
See added unit tests on the correctness of the calculation.
Was this patch authored or co-authored using generative AI tooling?
Yes. Generated-by cursor and 'claude-4-sonnet'